Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review and enhance tracing support for recommendation service (Python) #59

Closed
3 of 10 tasks
cartersocha opened this issue May 30, 2022 · 0 comments · Fixed by #163
Closed
3 of 10 tasks

Review and enhance tracing support for recommendation service (Python) #59

cartersocha opened this issue May 30, 2022 · 0 comments · Fixed by #163
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@cartersocha
Copy link
Contributor

cartersocha commented May 30, 2022 •
edited by julianocosta89
Loading

The following is a list of requirements that we need to evaluate before declaring v1 for trace telemetry. These requirements are across the entire application; Not all services will meet all requirements. Determine the relevant features for this service.

  • Automatic Instrumentation is being used where appropriate.
  • Library instrumentation is being used if automatic instrumentation is unavailable.
  • Services extend automatic instrumentation.
    • New attributes/events attached to existing spans.
    • New spans are being created from existing spans.
  • Automatic and Manual Context Propagation are being demonstrated.
    • Interprocess context propagation is demonstrated.
  • Telemetry is not being sampled upfront.
  • Telemetry is not being filtered upfront.
  • Baggage is being set and read appropriately (i.e., baggage must be explicitly set as attributes on spans)

Referencing: #42

Service: https://github.com/open-telemetry/opentelemetry-demo-webstore/blob/main/src/recommendationservice/README.md
@cartersocha cartersocha added enhancement New feature or request help wanted Extra attention is needed required-for-release labels May 30, 2022
@puckpuck puckpuck mentioned this issue Jun 23, 2022
Merged
3 tasks
smith pushed a commit to smith/opentelemetry-demo that referenced this issue Oct 8, 2024
@rogercoll
chore: bump Elastic agent distributions (open-telemetry#59)
c5cfd5c 
* chore: bump Elastic otel-node to 0.3.0

* chore: bump Elastic Otel dotnet

* chore: use latest Otel Java Agent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
No open projects
OpenTelemetry Community Demo - Completeness
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[recommendation] - add manual tracing instrumentation honeycombio/opentelemetry-demo
1 participant
@cartersocha