Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kubernetes manifest #1074

Closed
wants to merge 2 commits into from
Closed

Conversation

cedricziel
Copy link
Contributor

@cedricziel cedricziel commented Aug 22, 2023

Changes

This upgrades the helm chart from upstream and changed dependencies with it.

Namely:

  • otelcol-contrib to 0.82.0
  • prometheus to 2.46.0
  • grafana to 10.0.3
  • jaeger to 1.45.0

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

Relates to #995

@cedricziel cedricziel marked this pull request as ready for review August 22, 2023 15:14
@cedricziel cedricziel requested a review from a team August 22, 2023 15:14
@julianocosta89
Copy link
Member

Hello @cedricziel, thanks for taking care of this.
This is not the helm chart though.

Those are the kubernetes manifests and we have a make command for that: https://github.com/open-telemetry/opentelemetry-demo/blob/main/Makefile#L107, which updates the yaml based on the compose file.

We need to update the versions on the files:

And run:

make generate-kubernetes-manifests

@fatsheep9146
Copy link
Contributor

@cedricziel could you update as @julianocosta89 suggests?

@cedricziel cedricziel changed the title Update helm chart Update Kubernetes manifest Aug 23, 2023
@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@julianocosta89
Copy link
Member

@puckpuck if I got the make generate-kubernetes-manifests right, it will only work after updating the helm charts, right?!

If so, I'd vote to close this PR.

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Sep 16, 2023
@puckpuck
Copy link
Contributor

After this PR merges in the Helm chart repo (should be today), we will re-generated the Kubernetes manifest in another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants