Fix service graph by enabling client spans in envoy proxy #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
@cedricziel could you add a change log? |
|
@julianocosta89 done :) |
6 tasks
puckpuck
requested changes
Oct 16, 2023
puckpuck
approved these changes
Oct 20, 2023
julianocosta89
approved these changes
Oct 20, 2023
Dylan-M
pushed a commit
to observIQ/opentelemetry-demo
that referenced
this pull request
Oct 25, 2023
…etry#1180) * Enable client spans in envoy proxy * Changelog * Update CHANGELOG.md * Update envoy version --------- Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
Dylan-M
pushed a commit
to observIQ/opentelemetry-demo
that referenced
this pull request
Oct 25, 2023
…etry#1180) * Enable client spans in envoy proxy * Changelog * Update CHANGELOG.md * Update envoy version --------- Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
…etry#1180) * Enable client spans in envoy proxy * Changelog * Update CHANGELOG.md * Update envoy version --------- Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The service graph generator uses a pair of server -> client spans to determine relations for many
scenarios. The current configuration of envoy will only produce kind=server spans. This change enables
envoy to create relevant client spans.
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.mdupdated to document new feature additions