chore: add env var for pinning trace-based test tool version #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielbdias
approved these changes
Nov 8, 2023
julianocosta89
approved these changes
Nov 9, 2023
|
I'm actually writing such a blog post right now. That's how I noticed the demo had an issue, and created this PR. 😄 I'll keep you in the loop on progress. 👌 |
|
Hi! Since the docs PR open-telemetry/opentelemetry.io#3526 was merged, should we also merge this PR? |
3 tasks
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
…lemetry#1239) * chore: add env var for pinning tracetesting image version * chore: add odd profile and start command * chore: fix yamllint * chore: update changelog * chore: update makefile comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added an env var to make sure the same image version is used for the trace-based test tool. Currently the image version pin in the
tracetesting/Dockerfilediffers from the image version pin in thedocker-compose.yaml.Updated docs in this PR: open-telemetry/opentelemetry.io#3526
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.mdupdated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.