Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run tracetesting on successful build #1278

Merged
merged 13 commits into from
Nov 28, 2023

Conversation

austinlparker
Copy link
Member

this PR adds on-demand provisioning of an equinix metal runner to run tracetesting on a successful PR build

@austinlparker austinlparker requested a review from a team November 27, 2023 17:51
@mviitane
Copy link
Member

When I run the tracetest locally, I get an error about CLI at the end. Does this occur also with this runner?

$ make run-tracetesting
docker compose run traceBasedTests 
[+] Creating 21/0
 ✔ Container jaeger                   Running                                                                                                                                                                                                             0.0s 
 ✔ Container tracetest-postgres       Running                                                                                                                                                                                                             0.0s 
 ✔ Container postgres                 Running                                                                                                                                                                                                             0.0s 
 ✔ Container redis-cart               Running                                                                                                                                                                                                             0.0s 
 ✔ Container kafka                    Running                                                                                                                                                                                                             0.0s 
 ✔ Container feature-flag-service     Running                                                                                                                                                                                                             0.0s 
 ✔ Container otel-col                 Running                                                                                                                                                                                                             0.0s 
 ✔ Container email-service            Running                                                                                                                                                                                                             0.0s 
 ✔ Container product-catalog-service  Running                                                                                                                                                                                                             0.0s 
 ✔ Container tracetest-server         Running                                                                                                                                                                                                             0.0s 
 ✔ Container ad-service               Running                                                                                                                                                                                                             0.0s 
 ✔ Container quote-service            Running                                                                                                                                                                                                             0.0s 
 ✔ Container cart-service             Running                                                                                                                                                                                                             0.0s 
 ✔ Container recommendation-service   Running                                                                                                                                                                                                             0.0s 
 ✔ Container shipping-service         Running                                                                                                                                                                                                             0.0s 
 ✔ Container frauddetection-service   Running                                                                                                                                                                                                             0.0s 
 ✔ Container accounting-service       Running                                                                                                                                                                                                             0.0s 
 ✔ Container currency-service         Running                                                                                                                                                                                                             0.0s 
 ✔ Container payment-service          Running                                                                                                                                                                                                             0.0s 
 ✔ Container checkout-service         Running                                                                                                                                                                                                             0.0s 
 ✔ Container frontend                 Running                                                                                                                                                                                                             0.0s 
[+] Running 3/3
 ✔ Container postgres            Healthy                                                                                                                                                                                                                  0.5s 
 ✔ Container tracetest-postgres  Healthy                                                                                                                                                                                                                  0.5s 
 ✔ Container kafka               Healthy                                                                                                                                                                                                                  0.5s 
tracetest CLI could not be found
make: *** [run-tracetesting] Error 255

@austinlparker
Copy link
Member Author

I dunno, I can't actually run the runner through GHA until this is merged for a variety of reasons.

Copy link
Member

@mviitane mviitane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to try it out. Hard to say beforehand if it works.

@austinlparker austinlparker merged commit c9750dc into open-telemetry:main Nov 28, 2023
27 checks passed
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
* add CI

* fix lint

* fix name

* fix run

* change calling behavior

* add job names

* change secret

* inherit secrets

* change to pull_request_target

* remove secret inheritance

* change to run on pr merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants