Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deplecated function in otelgrpc for go #1284

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Replace deplecated function in otelgrpc for go #1284

merged 1 commit into from
Dec 1, 2023

Conversation

yuki0920
Copy link
Contributor

@yuki0920 yuki0920 commented Nov 30, 2023

Changes

I replaced deplecated functions with appropriate functions in otelgrpc for go.

In the docs, following functions are deprecated. Instead, NewClientHandler and NewServerHandler shoud be used.

StreamClientInterceptor
StreamServerInterceptor
UnaryClientInterceptor
UnaryServerInterceptor

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

Copy link

linux-foundation-easycla bot commented Nov 30, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: yuki0920 / name: Yuki Watanabe (6e58cc2)

@yuki0920 yuki0920 marked this pull request as ready for review November 30, 2023 13:04
@yuki0920 yuki0920 requested a review from a team as a code owner November 30, 2023 13:04
@austinlparker austinlparker merged commit 8124353 into open-telemetry:main Dec 1, 2023
27 checks passed
@yuki0920 yuki0920 deleted the fix/replase-deplecated-function-in-otelgrpc-go branch December 1, 2023 23:07
yuki0920 added a commit to yuki0920/opentelemetry.io that referenced this pull request Dec 2, 2023
I updated these docs to reflect the source code modifications.
See: open-telemetry/opentelemetry-demo#1284
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants