Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and semconv #1316

Conversation

julianocosta89
Copy link
Member

@julianocosta89 julianocosta89 commented Dec 30, 2023

Changes

This PR updates the dependencies of AccountingService, bumps semmantic conventions to 1.21 and adjust the code to remove the deprecated span attribute.

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@julianocosta89 julianocosta89 requested a review from a team December 30, 2023 00:21
Copy link
Member

@mviitane mviitane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julianocosta89 julianocosta89 merged commit 326ffe4 into open-telemetry:main Jan 2, 2024
27 checks passed
@julianocosta89 julianocosta89 deleted the accountingservice-Update-deps-and-semconv branch January 2, 2024 12:40
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
* Update dependencies and semconv

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants