Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken cartservice #145

Merged

Conversation

puckpuck
Copy link
Contributor

Fixes #.

Fixes #140

Please provide a brief description of the changes here.

Re-added and referenced the CartService implementation
Added ASPNETCORE_URLS to the environment stanza of the cartservice definition in docker-compose

@puckpuck puckpuck requested a review from a team June 17, 2022 00:58
Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally and everything is back to the working state! ❤️

Copy link
Member

@austinlparker austinlparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested in codespaces and everything is working, lgtm

@austinlparker austinlparker merged commit a0ce5bb into open-telemetry:main Jun 17, 2022
@puckpuck puckpuck deleted the puckpuck.fix-cartservice branch June 23, 2022 01:32
GaryPWhite pushed a commit to wayfair-contribs/opentelemetry-demo that referenced this pull request Jun 30, 2022
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getting connection refused with Cart Service
3 participants