Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Pass down image optimization requests to imageprovider in checkoutitem component #1529

Merged
merged 5 commits into from
Apr 15, 2024

Conversation

klucsik
Copy link
Contributor

@klucsik klucsik commented Apr 15, 2024

Changes

This fix addresses the missing image problem in #1525

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@klucsik klucsik marked this pull request as ready for review April 15, 2024 10:15
@klucsik klucsik requested a review from a team April 15, 2024 10:15
Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
@julianocosta89 julianocosta89 merged commit 4d84a64 into open-telemetry:main Apr 15, 2024
27 checks passed
AlexPSplunk pushed a commit to splunk/edu-opentelemetry-demo that referenced this pull request Jul 10, 2024
…checkoutitem component (open-telemetry#1529)

* [frontend] Pass down image optimization requests to imageprovider in checkoutitem component

* updating changelog

* Update CHANGELOG.md

---------

Co-authored-by: Austin Parker <austin@ap2.io>
Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants