[checkout] fix kafka restart #1590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
… checkout.fix-kafka-restart
|
@julianocosta89 I moved to use semantic conventions or attribute names that align closer to what already exists. Let me know if we still need to update them. |
julianocosta89
approved these changes
Jun 6, 2024
AlexPSplunk
pushed a commit
to splunk/edu-opentelemetry-demo
that referenced
this pull request
Jul 10, 2024
* fix kafka acks * Update src/checkoutservice/main.go Co-authored-by: Juliano Costa <julianocosta89@outlook.com> * align attribute names with semantic conventions * checkout: recover from kafka restart --------- Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
If Kafka is restarted, the checkout service will start to report very long response/acknowledgment times from Kafka. This may be due to the demo's unique configuration, which only has a single broker. To get around the issue, the Kafka/Sarama SDK is set to respond without full acknowledgments. This may lead to missed errors in certain situations but will allow the demo to recover from Kafka restarts and continue working without issues.
Part of this PR is to do proper handling of the Kafka message in a success or error scenario and also add attributes to the Kafka producer span related to details about the interaction with Kafka. A docs update will be required.
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.mdupdated to document new feature additions* [ ] Appropriate Helm chart updates in the helm-chartsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.