Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Valkey] Replace Redis with Valkey #1619

Merged

Conversation

julianocosta89
Copy link
Member

@julianocosta89 julianocosta89 commented Jun 20, 2024

Changes

This PR replaces Redis with Valkey.

Redis has recently changed its licensing and Valkey was created by the community to continue the project as an Open Source driven project.
Valkey/about:

The transition garnered substantial backing from leading tech corporations including AWS, Google, Oracle, Ericsson, and Snap, with the Linux Foundation stepping in to provide a stable platform for this new direction.

Linux Foundation Launches Open Source Valkey Community.

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@julianocosta89 julianocosta89 requested a review from a team as a code owner June 20, 2024 10:12
@github-actions github-actions bot added the helm-update-required Requires an update to the Helm chart when released label Jun 20, 2024
Copy link
Contributor

@rogercoll rogercoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Neat migration 👏

src/otelcollector/otelcol-config.yml Show resolved Hide resolved
@puckpuck puckpuck merged commit 11ef3c6 into open-telemetry:main Jun 21, 2024
29 checks passed
@julianocosta89 julianocosta89 deleted the replace-redis-with-valkey branch June 25, 2024 02:31
@rogercoll
Copy link
Contributor

Just opened this PR to update the helm charts: open-telemetry/opentelemetry-helm-charts#1232

(nightly images are failing with helm deployment)

@sorenlouv
Copy link

sorenlouv commented Jun 25, 2024

Edit: please disregard this comment - I think my problem is related to a fork of this repo

I am seeing this error locally from the cartservice and it is seemingly unable to start.

REDIS_ADDR environment variable is required.

Could that be related to this change?

AlexPSplunk pushed a commit to splunk/edu-opentelemetry-demo that referenced this pull request Jul 10, 2024
* replace redis with valkey

* changelog

---------

Co-authored-by: Mikko Viitanen <74129181+mviitane@users.noreply.github.com>
ahealy-newr pushed a commit to ahealy-newr/opentelemetry-demo-ahealy that referenced this pull request Jul 24, 2024
* replace redis with valkey

* changelog

---------

Co-authored-by: Mikko Viitanen <74129181+mviitane@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
helm-update-required Requires an update to the Helm chart when released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants