Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing an emailservice build problem. #172

Merged
merged 3 commits into from
Jun 27, 2022

Conversation

mviitane
Copy link
Member

Fixing an emailservice build problem.

The build is currently failing when running
docker-compose up

Problem:
Step 3/8 : COPY Gemfile* . When using COPY with more than one source file, the destination must be a directory and end with a / ERROR: Service 'emailservice' failed to build : Build failed

Changes

Dockerfile updated to fix the build.

@mviitane mviitane requested a review from a team June 27, 2022 13:29
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 27, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@mviitane
Copy link
Member Author

/easycla

1 similar comment
@jarias-lfx
Copy link

/easycla

@cartersocha
Copy link
Contributor

How do I recreate the issue? It seems to be working for me

@cartersocha
Copy link
Contributor

Just read through the docker files and this does look like a bug

@proffalken
Copy link

proffalken commented Jun 27, 2022

Can confirm this is not working for me on a clean build.

Building emailservice
Sending build context to Docker daemon  15.87kB
Step 1/8 : FROM ruby:3.1.2-slim
 ---> cd3f34899940
Step 2/8 : RUN apt-get update -y && apt-get install -y build-essential
 ---> Using cache
 ---> d0c0ba386e1c
Step 3/8 : COPY Gemfile* .
When using COPY with more than one source file, the destination must be a directory and end with a /
ERROR: Service 'emailservice' failed to build : Build failed

Applying the patch works fine:

Step 3/8 : COPY Gemfile* ./
 ---> b90f6c0feb5a
Step 4/8 : RUN bundle install
 ---> Running in e5de519c5cf0

@cartersocha cartersocha merged commit 48829b7 into open-telemetry:main Jun 27, 2022
@cartersocha
Copy link
Contributor

Thanks for verifying this @proffalken. Just merged the fix

@ahayworth
Copy link
Contributor

Huh - thanks for fixing everyone. Never saw this on my machine when implementing it, but I suppose that's why "works on my machine" is dangerous. 😄 ❤️

GaryPWhite pushed a commit to wayfair-contribs/opentelemetry-demo that referenced this pull request Jun 30, 2022
* Fixing an emailservice build fail problem.

* Fixing an emailservice build problem.

Co-authored-by: Carter Socha <43380952+cartersocha@users.noreply.github.com>
@mviitane mviitane deleted the email_build_fix branch February 2, 2024 13:20
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
* Fixing an emailservice build fail problem.

* Fixing an emailservice build problem.

Co-authored-by: Carter Socha <43380952+cartersocha@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants