fix: only register otel during initialization #1736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
rogercoll
reviewed
Oct 9, 2024
rogercoll
approved these changes
Oct 14, 2024
julianocosta89
approved these changes
Oct 14, 2024
benakansara
pushed a commit
to benakansara/opentelemetry-demo
that referenced
this pull request
Oct 15, 2024
* fix: only register otel during initialization Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com> * revert removal of fatal log --------- Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com> Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Move the feature flag hook registration to the main method. This prevents the hook from being registered on every request.
This change brings the
product-catalog-servicein line with thecheckout-service.https://github.com/open-telemetry/opentelemetry-demo/blob/main/src/checkoutservice/main.go#L163-L164
Merge Requirements
For new features contributions, please make sure you have completed the following
essential items:
CHANGELOG.mdupdated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.
Resolves: #1735