Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[collector] - allow for an extras configuration #246

Merged
merged 4 commits into from
Aug 3, 2022

Conversation

puckpuck
Copy link
Contributor

@puckpuck puckpuck commented Aug 1, 2022

Changes

Adds an "extras" configuration for the collector that can be used to specify additional settings that get merged on startup. This is particularly convenient for forks of this repo where export or additional telemetry processing is desired for the fork.

The otelcol-config-extras.yml file needs to exist or the collector startup will fail.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes

@puckpuck puckpuck requested a review from a team August 1, 2022 16:16
Copy link
Member

@mviitane mviitane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Some documentation could be added to describe when to use the extras config and explain that it fully replaces the default collector config.

@puckpuck puckpuck merged commit 8f994d8 into open-telemetry:main Aug 3, 2022
@puckpuck puckpuck deleted the collector-extras branch August 3, 2022 02:36
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
* use extras configuration for collector

* add extras collector config

* add extras collector config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants