add helm chart to main readme #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mic-max
approved these changes
Aug 3, 2022
|
@wph95 @TylerHelmuth any suggestions on information or doc structure? I tried to adapt the helm repo information & spotlight it |
TylerHelmuth
reviewed
Aug 3, 2022
There was a problem hiding this comment.
I think this is a good start. I think anything more (like common values.yaml options) would be better suited in the chart's readme. I do think it would be good to link directly to https://github.com/open-telemetry/opentelemetry-helm-charts/tree/main/charts/opentelemetry-demo somewhere in this doc.
TylerHelmuth
approved these changes
Aug 3, 2022
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
* add helm chart * changelog update * pr feedback * nit * add to prerequisites
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pointing to our helm chart in our docs