Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service table and graph cleanup #266

Merged
merged 8 commits into from
Aug 5, 2022
Merged

Service table and graph cleanup #266

merged 8 commits into from
Aug 5, 2022

Conversation

puckpuck
Copy link
Contributor

@puckpuck puckpuck commented Aug 5, 2022

Changes

  • Sorts Service table alphabetically on the service name
  • Updates service graph to reflect planned feature flag service usage
  • Adds links between table and graph

@puckpuck puckpuck requested a review from a team August 5, 2022 04:32
@cartersocha
Copy link
Contributor

tiny nit I'd add a period after the service table link

mviitane
mviitane approved these changes Aug 5, 2022
View reviewed changes
Copy link
Member

@mviitane mviitane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have the tables aligned.

@cartersocha cartersocha merged commit 8e8674f into open-telemetry:main Aug 5, 2022
@puckpuck puckpuck deleted the service_table-cleanup branch August 6, 2022 00:09
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
@puckpuck
Service table and graph cleanup (open-telemetry#266)
05f531d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mviitane mviitane mviitane approved these changes

@cartersocha cartersocha cartersocha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@puckpuck @cartersocha @mviitane