Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[featureflag] - remove hardcoded otlp endpoint #275

Merged
merged 4 commits into from
Aug 10, 2022

Conversation

puckpuck
Copy link
Contributor

@puckpuck puckpuck commented Aug 9, 2022

Fixes #274

Changes

Removes the hardcoded endpoint for the OTLP exporter and uses the OTEL_EXPORTER_OTLP_TRACES_ENDPOINT environment variable instead.

@puckpuck puckpuck requested review from tsloughter and a team August 9, 2022 04:06
@tsloughter
Copy link
Member

Could remove the whole config section for the exporter if you set OTEL_EXPORTER_OTLP_TRACES_PROTOCOL=grpc as well.

@puckpuck
Copy link
Contributor Author

Could remove the whole config section for the exporter if you set OTEL_EXPORTER_OTLP_TRACES_PROTOCOL=grpc as well.

updated to include this suggestion

@cartersocha cartersocha merged commit 0f4ccde into open-telemetry:main Aug 10, 2022
@puckpuck puckpuck deleted the ffs-use-otlp-env-vars branch August 10, 2022 02:40
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[featureflag] - OTLP export endpoint is hardcoded
5 participants