Added support for baggage read and Set as attributes, added sdk builders and Semantic changes #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyang
approved these changes
Aug 10, 2022
|
We've talked about adding session Id & some other baggage values. Is this creating a new baggage item? @austinlparker @puckpuck do we want services creating new baggage items or just reading the upstream baggage? We might need to change the requirements |
|
We aren't expecting the currency service to set anything in baggage. I think the frontend and/or checkout will add baggage that is read by downstream services. |
|
@DebajitDas if you can update the change log I will merge |
Updated @cartersocha |
|
Small lint error @DebajitDas |
The PR is ready to be merged now. @cartersocha |
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
…ers and Semantic changes (open-telemetry#281) * Updating grpc version * Baggage changes * Added Baggage support * Updated docs * Udpated client * update * update Readme * Updated Changelog Co-authored-by: Carter Socha <43380952+cartersocha@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52
Added support for baggage read and Set as attributes, added sdk builders and Semantic changes.
The baggage support is added with the assumption that baggage is expected in the header with key as "baggage" and value as string. There can be changes on this if the assumption is not correct.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes