Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github action create build env #324

Merged
merged 2 commits into from
Aug 19, 2022
Merged

github action create build env #324

merged 2 commits into from
Aug 19, 2022

Conversation

wph95
Copy link
Member

@wph95 wph95 commented Aug 19, 2022 •
edited
Loading

Fixes #323

Avoid reading env exceptions by generating a corresponding env file for dockerhub/gchr.

@wph95 wph95 requested a review from a team August 19, 2022 21:41
@wph95
Copy link
Member Author

wph95 commented Aug 19, 2022

used myself repo tested it
https://github.com/wph95/opentelemetry-demo-webstore/runs/7926351926?check_suite_focus=true

austinlparker
austinlparker approved these changes Aug 19, 2022
View reviewed changes
Copy link
Member

@austinlparker austinlparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gnarly but works for me

@austinlparker austinlparker merged commit 21d02e1 into open-telemetry:main Aug 19, 2022
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
@wph95
github action create build env (open-telemetry#324)
7980e2b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyang reyang reyang approved these changes

@austinlparker austinlparker austinlparker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release tag not being picked up by build
3 participants
@wph95 @austinlparker @reyang