Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README to mention that the emailservice is HTTP #351

Merged
merged 2 commits into from
Sep 6, 2022
Merged

Update README to mention that the emailservice is HTTP #351

merged 2 commits into from
Sep 6, 2022

Conversation

ahayworth
Copy link
Contributor

Changes

Clearly not an urgent PR, but I happened to notice that it didn't
mention that we have an HTTP service. I updated the docs to mention
that, and annotated the (quite nice) mermaid graph with the HTTP
annotation as well.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #

Clearly not an urgent PR, but I happened to notice that it didn't
mention that we have an HTTP service. I updated the docs to mention
that, and annotated the (quite nice) mermaid graph with the `HTTP`
annotation as well.
@ahayworth ahayworth requested a review from a team September 3, 2022 20:40
Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cartersocha cartersocha merged commit 513420b into open-telemetry:main Sep 6, 2022
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants