Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc/improve mermaid chart #404

Merged
merged 6 commits into from
Oct 7, 2022
Merged

Doc/improve mermaid chart #404

merged 6 commits into from
Oct 7, 2022

Conversation

julianocosta89
Copy link
Member

Fixes #27.

Changes

Added grpc & http communication labels to mermaid chart.

@julianocosta89 julianocosta89 added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 6, 2022
@julianocosta89 julianocosta89 self-assigned this Oct 6, 2022
@julianocosta89 julianocosta89 requested a review from a team October 6, 2022 19:55
@julianocosta89
Copy link
Member Author

A preview of the chart can be seen in here:
https://github.com/julianocosta89/opentelemetry-demo/tree/doc/improve-mermaid-chart#architecture

@julianocosta89
Copy link
Member Author

Checks / markdownlinkcheck failure not related to the PR:

ERROR: 2 dead links found!
[✖] https://github.com/austinlparker → Status: 500
[✖] https://github.com/mtwo → Status: 500

Any ideas how to solve this?

@reyang
Copy link
Member

reyang commented Oct 6, 2022

Checks / markdownlinkcheck failure not related to the PR:

ERROR: 2 dead links found!
[✖] https://github.com/austinlparker → Status: 500
[✖] https://github.com/mtwo → Status: 500

Any ideas how to solve this?

Wait for GitHub to recover and rerun the CI. Or ask the maintainer to forcibly merge the PR with the understanding that these failures were caused by GitHub transilient issue rather than caused by this PR.

@cartersocha cartersocha merged commit 92879d4 into open-telemetry:main Oct 7, 2022
@julianocosta89 julianocosta89 deleted the doc/improve-mermaid-chart branch October 7, 2022 14:38
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
@julianocosta89
Doc/improve mermaid chart (open-telemetry#404)
ff421bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyang reyang reyang approved these changes

@mic-max mic-max mic-max approved these changes

Assignees

@julianocosta89 julianocosta89

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider a Mermaid diagram?
4 participants
@julianocosta89 @reyang @mic-max @cartersocha