Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for creating a fork #447

Merged
merged 4 commits into from
Oct 14, 2022

Conversation

joshleecreates
Copy link
Contributor

Towards #267 (comment).

Changes

Adds some documentation around environment variables and values overrides for creating forks and demos.

@joshleecreates joshleecreates requested a review from a team October 14, 2022 17:59
@joshleecreates joshleecreates force-pushed the forking-docs branch 3 times, most recently from 9ad731d to 63f02b4 Compare October 14, 2022 18:06
README.md Show resolved Hide resolved
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cartersocha
Copy link
Contributor

@joshleecreates could you make the helm command a shell code block? It looks a bit odd with regular text alongside it

@cartersocha
Copy link
Contributor

Lol my comment obscures the formatting but something like " ```shell "

Should work

@joshleecreates
Copy link
Contributor Author

Lol my comment obscures the formatting but something like " ```shell "

Should work

Yes will do.. lol.

@cartersocha
Copy link
Contributor

Lgtm

@cartersocha cartersocha merged commit 9d1e782 into open-telemetry:main Oct 14, 2022
@joshleecreates joshleecreates deleted the forking-docs branch October 16, 2022 14:20
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants