-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure random ads code branch is exercised by the load generator #656
Ensure random ads code branch is exercised by the load generator #656
Conversation
Hi I wonder if 'This is in preparation for #73.', what metric do you want to provide if this pr is merged? |
085abb4
to
cd7762d
Compare
I was thinking of an ad requests counter with two dimensions: request type of either targeted or "not targeted", and response type of either targeted or random. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have permission to use this image from National Geographic?
Maybe it was mentioned in a SIG meeting that I missed, but can we get a detailed plan in the #73 issue? I'm ok with adding another product and category, but if this is in reference to that issue, I would like to understand what the bigger picture looks like. |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Hmm, good point. Any tips on where to get images where licensing won't be an issue? Alternatively, we don't strictly need to add a new product in order have the load generator exercise the random ads code branch since the load generator is hitting the ads API directly. |
Sorry, I didn't realize this would be appropriate fodder for the SIG meeting. I'm happy to bring it up at the next meeting. |
dbe3f87
to
032ec19
Compare
I've updated the new product to use a creative common licensed image. |
Providing color in issue #73 itself would be fine as well. I just want to understand the big picture. |
I've added a couple of paragraphs describing my general proposal in #73, let me know what you think. |
6cd8c9a
to
2ec278e
Compare
to be merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
…n-telemetry#656) * Ensure random ads code branch is exercised by the load generator * Switching to new product with image under CC license Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
Changes
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.md
updated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.