Add resource detectors to product catalog service #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: svrnm <neumanns@cisco.com>
Signed-off-by: svrnm <neumanns@cisco.com>
fatsheep9146
approved these changes
Jan 10, 2023
2 tasks
|
@svrnm this one should be good to go. Could you take care of the merge conflicts? |
Signed-off-by: Severin Neumann <severin.neumann@altmuehlnet.de>
Signed-off-by: Severin Neumann <severin.neumann@altmuehlnet.de>
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
* Add resource detectors to product catalog service Signed-off-by: svrnm <neumanns@cisco.com> * Set PR id in changelog Signed-off-by: svrnm <neumanns@cisco.com> * restore go.mod and go.sum from current main Signed-off-by: Severin Neumann <severin.neumann@altmuehlnet.de> * add resources to metrics Signed-off-by: Severin Neumann <severin.neumann@altmuehlnet.de> Signed-off-by: svrnm <neumanns@cisco.com> Signed-off-by: Severin Neumann <severin.neumann@altmuehlnet.de> Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: svrnm neumanns@cisco.com
Changes
Same as #676, but the product catalog service required some updates for the OpenTelemetry dependencies so I put it into a seperate PR
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.mdupdated to document new feature additions