-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid calling obsolete methods #746
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for taking care of this @sungam3r! |
Please add a changelog entry @sungam3r and we're good to go! |
Could we merge without changelog, and let changelog be sent separately? So as to unblock open-telemetry/opentelemetry.io#2330 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested running this branch and all LGTM!
* Update example * remmove console --------- Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
* Update example * remmove console --------- Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
* Update example * remmove console --------- Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
Rel: open-telemetry/opentelemetry.io#2330