Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid calling obsolete methods #746

Merged
merged 3 commits into from
Feb 22, 2023
Merged

Conversation

sungam3r
Copy link
Contributor

src/cartservice/src/Program.cs Outdated Show resolved Hide resolved
src/cartservice/src/cartservice.csproj Outdated Show resolved Hide resolved
Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julianocosta89
Copy link
Member

Thanks for taking care of this @sungam3r!

@cartersocha
Copy link
Contributor

Please add a changelog entry @sungam3r and we're good to go!

@cijothomas
Copy link
Member

Please add a changelog entry @sungam3r and we're good to go!

Could we merge without changelog, and let changelog be sent separately? So as to unblock open-telemetry/opentelemetry.io#2330

Copy link
Contributor

@puckpuck puckpuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested running this branch and all LGTM!

@puckpuck puckpuck merged commit 8ef309f into open-telemetry:main Feb 22, 2023
@sungam3r sungam3r deleted the obsolete branch February 22, 2023 08:16
styblope pushed a commit to instana/opentelemetry-demo that referenced this pull request Mar 12, 2023
* Update example

* remmove console

---------

Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
juliangiuca pushed a commit to juliangiuca/opentelemetry-demo that referenced this pull request Apr 12, 2023
* Update example

* remmove console

---------

Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
* Update example

* remmove console

---------

Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants