Include omitted systems

open-telemetry · Jan 15, 2023 · c8cdaa4 · c8cdaa4
1 parent ed5132e
commit c8cdaa4
Showing 1 changed file with 9 additions and 10 deletions.
diff --git a/...y.Instrumentation.EntityFrameworkCore/Implementation/EntityFrameworkDiagnosticListener.cs b/...y.Instrumentation.EntityFrameworkCore/Implementation/EntityFrameworkDiagnosticListener.cs
@@ -114,15 +114,15 @@ public override void OnCustom(string name, Activity activity, object payload)
                                 activity.AddTag(AttributeDbSystem, "mysql");
                                 break;
                             case "Npgsql.EntityFrameworkCore.PostgreSQL":
+                            case "Devart.Data.PostgreSql.EFCore":
                                 activity.AddTag(AttributeDbSystem, "postgresql");
                                 break;
                             case "Oracle.EntityFrameworkCore":
                             case "Devart.Data.Oracle.EFCore":
-                            case "Devart.Data.PostgreSql.EFCore":
                                 activity.AddTag(AttributeDbSystem, "oracle");
                                 break;
                             case "Microsoft.EntityFrameworkCore.InMemory":
-                                activity.AddTag(AttributeDbSystem, "efcore-in-memory");
+                                activity.AddTag(AttributeDbSystem, "efcore_in_memory");
                                 break;
                             case "FirebirdSql.EntityFrameworkCore.Firebird":
                                 activity.AddTag(AttributeDbSystem, "firebird");
@@ -132,26 +132,25 @@ public override void OnCustom(string name, Activity activity, object payload)
                                 break;
                             case "EntityFrameworkCore.SqlServerCompact35":
                             case "EntityFrameworkCore.SqlServerCompact40":
-                                activity.AddTag(AttributeDbSystem, "sqlserver-compact");
+                                activity.AddTag(AttributeDbSystem, "mssql_compact");
                                 break;
                             case "EntityFrameworkCore.OpenEdge":
                                 activity.AddTag(AttributeDbSystem, "openedge");
                                 break;
-                            case "IBM.EntityFrameworkCore":
-                            case "IBM.EntityFrameworkCore-lnx":
-                            case "IBM.EntityFrameworkCore-osx":
-                                //outstanding questions
-                                activity.AddTag(AttributeDbSystem, "db2-or-informix");
-                                break;
                             case "EntityFrameworkCore.Jet":
                                 activity.AddTag(AttributeDbSystem, "jet");
                                 break;
                             case "Google.Cloud.EntityFrameworkCore.Spanner":
-                                activity.AddTag(AttributeDbSystem, "gcp-spanner");
+                                activity.AddTag(AttributeDbSystem, "gcp_spanner");
                                 break;
                             case "Teradata.EntityFrameworkCore":
                                 activity.AddTag(AttributeDbSystem, "teradata");
                                 break;
+                            case "IBM.EntityFrameworkCore":
+                            case "IBM.EntityFrameworkCore-lnx":
+                            case "IBM.EntityFrameworkCore-osx":
+                                activity.AddTag(AttributeDbSystem, "ibmdb");
+                                break;
                             default:
                                 activity.AddTag(AttributeDbSystem, "other_sql");
                                 activity.AddTag("ef.provider", providerName);