Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ASP.NET Core] .NET7+ ActivitySource selection logic #1741

Open
CodeBlanch opened this issue Jan 31, 2023 · 0 comments
Open

[ASP.NET Core] .NET7+ ActivitySource selection logic #1741

CodeBlanch opened this issue Jan 31, 2023 · 0 comments
Labels
comp:instrumentation.aspnetcore Things related to OpenTelemetry.Instrumentation.AspNetCore question Further information is requested

Comments

@CodeBlanch
Copy link
Member

Today if we detect .NET 7 or greater we resolve the ActivitySource to listen to using the IServiceProvider. This is to mirror what ASP.NET Core does under the hood. See: AddAspNetCoreInstrumentationSources.

@noahfalk Left a comment suggesting that we just listen to the default source by name.

Opening this issue to track the discussion further.
@CodeBlanch CodeBlanch added the question Further information is requested label Jan 31, 2023
@CodeBlanch CodeBlanch mentioned this issue Jan 31, 2023
Merged
3 tasks
@vishweshbankwar vishweshbankwar mentioned this issue Dec 13, 2023
Closed
4 tasks
@reyang reyang transferred this issue from open-telemetry/opentelemetry-dotnet May 13, 2024
@reyang reyang added the comp:instrumentation.aspnetcore Things related to OpenTelemetry.Instrumentation.AspNetCore label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp:instrumentation.aspnetcore Things related to OpenTelemetry.Instrumentation.AspNetCore question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@reyang @CodeBlanch