-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DI] Remove ConfigureBuilder and add implementation factory helpers #4103
Merged
CodeBlanch
merged 7 commits into
open-telemetry:main
from
CodeBlanch:configurebuilder-editorbrowsable
Jan 31, 2023
Merged
[DI] Remove ConfigureBuilder and add implementation factory helpers #4103
CodeBlanch
merged 7 commits into
open-telemetry:main
from
CodeBlanch:configurebuilder-editorbrowsable
Jan 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main open-telemetry/opentelemetry-dotnet#4103 +/- ##
==========================================
+ Coverage 85.52% 85.63% +0.10%
==========================================
Files 293 293
Lines 11329 11359 +30
==========================================
+ Hits 9689 9727 +38
+ Misses 1640 1632 -8
|
alanwest
reviewed
Jan 26, 2023
src/OpenTelemetry/Trace/Builder/TracerProviderBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
alanwest
reviewed
Jan 27, 2023
src/OpenTelemetry.Instrumentation.AspNetCore/TracerProviderBuilderExtensions.cs
Show resolved
Hide resolved
CodeBlanch
changed the title
[DI] Hide ConfigureBuilder and add implementation factory helpers
[DI] Remove ConfigureBuilder and add implementation factory helpers
Jan 28, 2023
alanwest
approved these changes
Jan 30, 2023
This was referenced May 13, 2024
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ConfigureBuilder
.ConfigureBuilder
.Note:
ConfigureBuilder
functionality is still available by casting the builder to eitherIDeferredTracerProviderBuilder
orIDeferredMeterProviderBuilder
.Public API Changes
OpenTelemetry.Extensions.DependencyInjection
OpenTelemetry
TODOs
CHANGELOG.md
updated for non-trivial changesNote: Documentation updates will be done in a follow-up PR.