Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #125:Adding enricher for Wcf instrumentation #126

Merged
merged 13 commits into from
Jun 15, 2021
Merged

Issue #125:Adding enricher for Wcf instrumentation #126

merged 13 commits into from
Jun 15, 2021

Conversation

epaulsen
Copy link
Contributor

@epaulsen epaulsen commented Jun 3, 2021

No description provided.

@epaulsen epaulsen requested a review from CodeBlanch as a code owner June 3, 2021 10:49
@epaulsen epaulsen requested a review from a team June 3, 2021 10:49
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 3, 2021 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Jun 7, 2021 •
edited
Loading

Codecov Report

Merging #126 (b949816) into main (e6b225e) will increase coverage by 0.01%.
The diff coverage is 81.25%.

❗ Current head b949816 differs from pull request most recent head 24ac5d7. Consider uploading reports for the commit 24ac5d7 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #126      +/-   ##
==========================================
+ Coverage   79.36%   79.38%   +0.01%     
==========================================
  Files          67       67              
  Lines        1764     1780      +16     
==========================================
+ Hits         1400     1413      +13     
- Misses        364      367       +3
Impacted Files Coverage Δ
...cf/Implementation/WcfInstrumentationEventSource.cs 26.31% <40.00%> (+4.88%) ⬆️
...rumentation.Wcf/TelemetryClientMessageInspector.cs 82.89% <100.00%> (+2.59%) ⬆️
...b.Instrumentation.Wcf/WcfInstrumentationOptions.cs 90.00% <100.00%> (+1.11%) ⬆️

epaulsen added 2 commits June 7, 2021 07:23
@epaulsen
Code review changes:
53bdce9 
1.  Changing classname WcfEventNames -> WcfEnrichEventNames
2.  Adding exception-logging for TelemetryClientMessageInspector
    and TelemetryDispatchMessageInspector
3.  Updating example code in readme to use constant event names
4.  Adding exception handling and event logging to enrichment
    operations.
@epaulsen
Merge branch 'main' of https://github.com/epaulsen/opentelemetry-dotn…
ed1d0e9 
…et-contrib into main
@epaulsen
Copy link
Contributor Author

epaulsen commented Jun 7, 2021

@CodeBlanch , thanks for the review.
I've updated my pullrequest based on your comments, do you mind having another look?

CodeBlanch
CodeBlanch approved these changes Jun 7, 2021
View reviewed changes
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @epaulsen this LGTM! I'm going to leave it open for a day or two just in case anyone else wants to also take a look at it.

cijothomas
cijothomas approved these changes Jun 11, 2021
View reviewed changes
Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of places uses AddTag. Please move to SetTag

@cijothomas
Copy link
Member

couple of places uses AddTag. Please move to SetTag

Can you fix the CI failures as well?

@epaulsen
Copy link
Contributor Author

Fixed markdownlint errors and added more tests so that code coverage does not decrease.

@cijothomas
Copy link
Member

@epaulsen One last CI failure remaining. Can you fix that too?

@epaulsen
Copy link
Contributor Author

@cijothomas I think I fixed the last code check error, mind running the workflows again? Sorry for all the failures, would have been easier if I could have executed the workflows my self.

@cijothomas
Copy link
Member

@cijothomas I think I fixed the last code check error, mind running the workflows again? Sorry for all the failures, would have been easier if I could have executed the workflows my self.

No problem. The workflows are automatically triggered. Since you are first-time contributor to this repo, it require a manual override by an approver. This shouldn't be an issue next time onwards!

@cijothomas cijothomas merged commit df49552 into open-telemetry:main Jun 15, 2021
@CodeBlanch
Copy link
Member

https://www.nuget.org/packages/OpenTelemetry.Contrib.Instrumentation.Wcf/1.0.0-rc2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodeBlanch CodeBlanch CodeBlanch approved these changes

@cijothomas cijothomas cijothomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@epaulsen @cijothomas @CodeBlanch