Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump SDK version #1301

Merged

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Aug 9, 2023

@utpilla utpilla requested a review from a team August 9, 2023 21:39
@CodeBlanch
Copy link
Member

@utpilla FYI it looks like a lot of the CI in this repo passes a channel to setup-dotnet for example:

with:
dotnet-version: '7.0.x'

I think we could remove that and it will just defer to whatever is defined in global.json. Less junk to modify anytime we bump the SDK that way 😄

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #1301 (a3947c0) into main (e0eeb0a) will increase coverage by 0.30%.
Report is 9 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1301      +/-   ##
==========================================
+ Coverage   73.83%   74.13%   +0.30%     
==========================================
  Files         264      256       -8     
  Lines        9386     9345      -41     
==========================================
- Hits         6930     6928       -2     
+ Misses       2456     2417      -39     
Files Changed Coverage Δ
...ry.Exporter.Geneva/TLDExporter/TldTraceExporter.cs 32.31% <ø> (ø)
...on.AWS/Implementation/AWSTracingPipelineHandler.cs 87.75% <ø> (ø)
...tion.AWS/Implementation/SnsRequestContextHelper.cs 95.00% <ø> (ø)
...tion.AWS/Implementation/SqsRequestContextHelper.cs 95.00% <ø> (ø)
...ntation.AWSLambda/Implementation/AWSLambdaUtils.cs 81.57% <ø> (ø)
...ResourceDetectors.Azure/AzureVmMetadataResponse.cs 94.28% <ø> (ø)
src/OpenTelemetry.Sampler.AWS/RateLimiter.cs 100.00% <ø> (ø)
...c/OpenTelemetry.Sampler.AWS/RateLimitingSampler.cs 100.00% <ø> (ø)
...Lambda/Implementation/AWSLambdaResourceDetector.cs 100.00% <100.00%> (ø)
...ation.AWSLambda/TracerProviderBuilderExtensions.cs 100.00% <100.00%> (ø)
... and 1 more

... and 8 files with indirect coverage changes

Copy link
Member

@alanwest alanwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alanwest alanwest merged commit cff9c0e into open-telemetry:main Aug 9, 2023
@@ -1,4 +1,4 @@
name: Pack OpenTelemetry.Instrumentation.StackExchangeRedis
Profilername: Pack OpenTelemetry.Instrumentation.StackExchangeRedis
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@utpilla What's up with this "Profiler" bit? Copy/paste fail?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! And yes looks like a terrible copy/paste fail 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants