-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump SDK version #1301
Bump SDK version #1301
Conversation
utpilla
commented
Aug 9, 2023
•
edited
Loading
edited
- Similar to [repo] Cleanup unused using statements opentelemetry-dotnet#4759
- Simplify dotnet-setup in CI workflows
@utpilla FYI it looks like a lot of the CI in this repo passes a channel to opentelemetry-dotnet-contrib/.github/workflows/ci.yml Lines 31 to 32 in b0e0828
I think we could remove that and it will just defer to whatever is defined in global.json. Less junk to modify anytime we bump the SDK that way 😄 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1301 +/- ##
==========================================
+ Coverage 73.83% 74.13% +0.30%
==========================================
Files 264 256 -8
Lines 9386 9345 -41
==========================================
- Hits 6930 6928 -2
+ Misses 2456 2417 -39
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
@@ -1,4 +1,4 @@ | |||
name: Pack OpenTelemetry.Instrumentation.StackExchangeRedis | |||
Profilername: Pack OpenTelemetry.Instrumentation.StackExchangeRedis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@utpilla What's up with this "Profiler" bit? Copy/paste fail?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch! And yes looks like a terrible copy/paste fail 😂