ResourceDetectors - Host #1507
Merged
ResourceDetectors - Host #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kielek
added
the
comp:resources.host
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1507 +/- ##
==========================================
- Coverage 73.91% 73.36% -0.56%
==========================================
Files 267 255 -12
Lines 9615 9422 -193
==========================================
- Hits 7107 6912 -195
- Misses 2508 2510 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lachmatt
approved these changes
Dec 20, 2023
cijothomas
reviewed
Dec 20, 2023
cijothomas
reviewed
Dec 20, 2023
cijothomas
reviewed
Dec 20, 2023
| build-test-host: | ||
| needs: detect-changes | ||
| if: | | ||
| contains(needs.detect-changes.outputs.changes, 'host') |
There was a problem hiding this comment.
"host" is too generic? Maybe something more narrow like ResourceDetector.host, if feasible.
There was a problem hiding this comment.
It is in sync with current pattern. Will be handled in scope of #1513 for all packages (for process we have already names conflict).
cijothomas
reviewed
Dec 20, 2023
cijothomas
reviewed
Dec 20, 2023
| <MinVerTagPrefix>ResourceDetectors.Host-</MinVerTagPrefix> | ||
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <PackageReference Include="OpenTelemetry" Version="1.6.0" /> |
There was a problem hiding this comment.
From PR description:
The plan is to release shortly as alpha with reference to OTel 1.6.0.
Then create follow up help-wanted issue to extend it for another attributes and update OTel to 1.7.0.
Will do, just after initial release.
cijothomas
approved these changes
Dec 20, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes N/A
Changes
Initial implementation for
host.namedetector from https://github.com/open-telemetry/semantic-conventions/blob/main/docs/resource/host.md (this attribute is what I need for now).The plan is to release shortly as alpha with reference to OTel 1.6.0.
Then create follow up
help-wantedissue to extend it for another attributes and update OTel to 1.7.0.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes[ ] Design discussion issue #Notes
Similar pr for process: #1506