-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ResourceDetectors.AWS] mark class as sealed #1510
Merged
cijothomas
merged 9 commits into
open-telemetry:main
from
Kielek:resource-detector-aws-mark-class-as-sealed
Jan 19, 2024
Merged
[ResourceDetectors.AWS] mark class as sealed #1510
cijothomas
merged 9 commits into
open-telemetry:main
from
Kielek:resource-detector-aws-mark-class-as-sealed
Jan 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kielek
added
the
comp:resources.aws
Things related to OpenTelemetry.Resources.AWS
label
Dec 20, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1510 +/- ##
==========================================
+ Coverage 73.91% 80.58% +6.66%
==========================================
Files 267 113 -154
Lines 9615 3054 -6561
==========================================
- Hits 7107 2461 -4646
+ Misses 2508 593 -1915
Flags with carried forward coverage won't be shown. Click here to find out more.
|
utpilla
reviewed
Dec 20, 2023
cijothomas
approved these changes
Dec 20, 2023
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
srprash
approved these changes
Jan 18, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes N/A
Changes
Mark class as sealed/static.
For significant contributions please make sure you have completed the following items:
[ ] AppropriateCHANGELOG.md
updated for non-trivial changes[ ] Design discussion issue #[ ] Changes in public API reviewed