Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup publicApi files #1711

Merged
merged 1 commit into from
May 9, 2024
Merged

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented May 9, 2024

Remove duplication where possible

Fixes #1692.

Changes

Cleanup publicApi files
Remove duplication where possible

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • [ ] Appropriate CHANGELOG.md updated for non-trivial changes
  • [ ] Design discussion issue #
  • Changes in public API reviewed

Remove duplication where possible
@Kielek Kielek added the infra Infra work - CI/CD, code coverage, linters label May 9, 2024
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.02%. Comparing base (71655ce) to head (be642ff).
Report is 228 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1711      +/-   ##
==========================================
+ Coverage   73.91%   80.02%   +6.10%     
==========================================
  Files         267      183      -84     
  Lines        9615     5131    -4484     
==========================================
- Hits         7107     4106    -3001     
+ Misses       2508     1025    -1483     
Flag Coverage Δ
unittests-Extensions 79.33% <ø> (?)
unittests-Instrumentation.AspNet 74.69% <ø> (?)
unittests-Instrumentation.AspNetCore 85.27% <ø> (?)
unittests-Instrumentation.EventCounters 76.36% <ø> (?)
unittests-Instrumentation.Owin 83.43% <ø> (?)
unittests-Instrumentation.Process 100.00% <ø> (?)
unittests-Instrumentation.Runtime 100.00% <ø> (?)
unittests-Instrumentation.StackExchangeRedis 71.00% <ø> (?)
unittests-PersistentStorage 65.78% <ø> (?)
unittests-ResourceDetectors.Azure 81.53% <ø> (?)
unittests-ResourceDetectors.Host 54.11% <ø> (?)
unittests-ResourceDetectors.Process 100.00% <ø> (?)
unittests-ResourceDetectors.ProcessRuntime 76.08% <ø> (?)
unittests-Solution 80.17% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 275 files with indirect coverage changes

@Kielek Kielek marked this pull request as ready for review May 9, 2024 10:05
@Kielek Kielek requested a review from a team May 9, 2024 10:05
@Kielek Kielek merged commit 46b27bc into open-telemetry:main May 9, 2024
104 checks passed
@Kielek Kielek deleted the cleanup-public-api-files branch May 9, 2024 17:00
@Kielek Kielek mentioned this pull request Jun 5, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Infra work - CI/CD, code coverage, linters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce the amount of public API files
4 participants