Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Exporter.Geneva] Add TraceState support #1850

Merged

Conversation

xiang17
Copy link
Contributor

@xiang17 xiang17 commented May 30, 2024

Add TraceState support in Geneva exporter.

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 64.28571% with 5 lines in your changes missing coverage. Please review.

Project coverage is 65.57%. Comparing base (71655ce) to head (123f26e).
Report is 304 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1850      +/-   ##
==========================================
- Coverage   73.91%   65.57%   -8.35%     
==========================================
  Files         267       35     -232     
  Lines        9615     3660    -5955     
==========================================
- Hits         7107     2400    -4707     
+ Misses       2508     1260    -1248     
Flag Coverage Δ
unittests-Exporter.Geneva 65.57% <64.28%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...Telemetry.Exporter.Geneva/GenevaExporterOptions.cs 90.24% <100.00%> (+0.24%) ⬆️
...ter.Geneva/MsgPackExporter/MsgPackTraceExporter.cs 94.83% <100.00%> (+2.41%) ⬆️
...ry.Exporter.Geneva/TLDExporter/TldTraceExporter.cs 32.75% <16.66%> (+0.44%) ⬆️

... and 248 files with indirect coverage changes

@xiang17 xiang17 marked this pull request as ready for review May 30, 2024 02:23
@xiang17 xiang17 requested a review from a team May 30, 2024 02:23
Copy link
Contributor

@rajkumar-rangaraj rajkumar-rangaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@utpilla utpilla added the comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva label May 30, 2024
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vishweshbankwar vishweshbankwar merged commit 0819114 into open-telemetry:main Jun 13, 2024
57 checks passed
@xiang17 xiang17 deleted the xiang17/AddTraceStateSupport branch June 14, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants