-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Resources.AWS] Prevent potential deadlocks by removing .Result calls #1922
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1922 +/- ##
==========================================
+ Coverage 73.91% 77.93% +4.01%
==========================================
Files 267 12 -255
Lines 9615 290 -9325
==========================================
- Hits 7107 226 -6881
+ Misses 2508 64 -2444
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@joegoldman2 - thanks for your contribution! |
@ppittle, @joegoldman2 - do you think that it is worth to document in changelog? |
I would say no. I see the change as a implementation detail that should not change the behavior. |
Changes
Prevent potential deadlocks by removing .Result calls in favour of
TaskFactory.StartNew(...)
.More context: #1699 (comment)
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes