Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Resources.AWS] Prevent potential deadlocks by removing .Result calls #1922

Merged
merged 4 commits into from
Jun 28, 2024

Conversation

joegoldman2
Copy link
Contributor

Changes

Prevent potential deadlocks by removing .Result calls in favour of TaskFactory.StartNew(...).

More context: #1699 (comment)

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@joegoldman2 joegoldman2 requested a review from a team as a code owner June 22, 2024 15:26
@github-actions github-actions bot requested review from ppittle and srprash June 22, 2024 15:26
@github-actions github-actions bot added the comp:resources.aws Things related to OpenTelemetry.Resources.AWS label Jun 22, 2024
Copy link

codecov bot commented Jun 22, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.93%. Comparing base (71655ce) to head (27d8ade).
Report is 346 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1922      +/-   ##
==========================================
+ Coverage   73.91%   77.93%   +4.01%     
==========================================
  Files         267       12     -255     
  Lines        9615      290    -9325     
==========================================
- Hits         7107      226    -6881     
+ Misses       2508       64    -2444     
Flag Coverage Δ
unittests-Resources.AWS 77.93% <84.61%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/OpenTelemetry.Resources.AWS/AWSECSDetector.cs 87.87% <100.00%> (ø)
src/OpenTelemetry.Resources.AWS/AsyncHelper.cs 100.00% <100.00%> (ø)
...enTelemetry.Resources.AWS/ResourceDetectorUtils.cs 100.00% <100.00%> (ø)
src/OpenTelemetry.Resources.AWS/AWSEC2Detector.cs 74.28% <33.33%> (ø)
src/OpenTelemetry.Resources.AWS/AWSEKSDetector.cs 58.62% <0.00%> (ø)

... and 274 files with indirect coverage changes

@ppittle
Copy link
Member

ppittle commented Jun 27, 2024

@joegoldman2 - thanks for your contribution!

@Kielek
Copy link
Contributor

Kielek commented Jun 28, 2024

@ppittle, @joegoldman2 - do you think that it is worth to document in changelog?

@joegoldman2
Copy link
Contributor Author

I would say no. I see the change as a implementation detail that should not change the behavior.

@Kielek Kielek merged commit c5cf3a4 into open-telemetry:main Jun 28, 2024
57 checks passed
@joegoldman2 joegoldman2 deleted the sync-over-async branch June 28, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:resources.aws Things related to OpenTelemetry.Resources.AWS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants