Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Resources.OperatingSystem] Fix issue with detecting MacOS #1965

Merged
merged 12 commits into from
Jul 22, 2024

Conversation

ysolomchenko
Copy link
Contributor

@ysolomchenko ysolomchenko commented Jul 17, 2024

Fixes # Fix issue with detecting MacOS

Changes

Fix issue with detecting MacOS

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@github-actions github-actions bot requested review from Kielek and lachmatt July 17, 2024 09:01
@github-actions github-actions bot added the comp:resources.operatingsystem Things related to OpenTelemetry.Resources.OperatingSystem label Jul 17, 2024
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.69%. Comparing base (71655ce) to head (c574011).
Report is 364 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1965      +/-   ##
==========================================
+ Coverage   73.91%   74.69%   +0.77%     
==========================================
  Files         267      299      +32     
  Lines        9615    11144    +1529     
==========================================
+ Hits         7107     8324    +1217     
- Misses       2508     2820     +312     
Flag Coverage Δ
unittests-Exporter.Geneva 64.97% <ø> (?)
unittests-Exporter.InfluxDB 95.88% <ø> (?)
unittests-Exporter.Instana 71.24% <ø> (?)
unittests-Exporter.OneCollector 91.51% <ø> (?)
unittests-Exporter.Stackdriver 75.73% <ø> (?)
unittests-Extensions 86.23% <ø> (?)
unittests-Extensions.AWS 77.24% <ø> (?)
unittests-Extensions.Enrichment 100.00% <ø> (?)
unittests-Instrumentation.AWS 87.56% <ø> (?)
unittests-Instrumentation.AWSLambda 87.96% <ø> (?)
unittests-Instrumentation.AspNetCore 85.27% <ø> (?)
unittests-Instrumentation.ElasticsearchClient 79.87% <ø> (?)
unittests-Instrumentation.EntityFrameworkCore 55.49% <ø> (?)
unittests-Instrumentation.EventCounters 76.36% <ø> (?)
unittests-Instrumentation.GrpcNetClient 79.61% <ø> (?)
unittests-Instrumentation.Hangfire 93.58% <ø> (?)
unittests-Instrumentation.Http 81.41% <ø> (?)
unittests-Instrumentation.Owin 83.43% <ø> (?)
unittests-Instrumentation.Process 100.00% <ø> (?)
unittests-Instrumentation.Quartz 78.94% <ø> (?)
unittests-Instrumentation.Runtime 100.00% <ø> (?)
unittests-Instrumentation.SqlClient 91.89% <ø> (?)
unittests-Instrumentation.StackExchangeRedis 67.02% <ø> (?)
unittests-Instrumentation.Wcf 48.91% <ø> (?)
unittests-PersistentStorage 65.78% <ø> (?)
unittests-Resources.AWS 77.93% <ø> (?)
unittests-Resources.Azure 82.83% <ø> (?)
unittests-Resources.Container 72.41% <ø> (?)
unittests-Resources.Gcp 72.54% <ø> (?)
unittests-Resources.Host 50.00% <ø> (?)
unittests-Resources.OperatingSystem 81.25% <80.00%> (?)
unittests-Resources.Process 100.00% <ø> (?)
unittests-Resources.ProcessRuntime 94.11% <ø> (?)
unittests-Sampler.AWS 87.97% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...sources.OperatingSystem/OperatingSystemDetector.cs 78.57% <80.00%> (ø)

... and 311 files with indirect coverage changes

@github-actions github-actions bot added the infra Infra work - CI/CD, code coverage, linters label Jul 18, 2024
@ysolomchenko ysolomchenko force-pushed the fix-operating-system-detector branch from 737d35e to 3f75811 Compare July 18, 2024 07:13
@ysolomchenko ysolomchenko marked this pull request as ready for review July 18, 2024 09:39
@ysolomchenko ysolomchenko requested a review from a team July 18, 2024 09:39
Co-authored-by: Robert Pająk <pellared@hotmail.com>
@Kielek Kielek merged commit 269a3b8 into open-telemetry:main Jul 22, 2024
289 checks passed
ezhang6811 pushed a commit to ezhang6811/opentelemetry-dotnet-contrib that referenced this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:resources.operatingsystem Things related to OpenTelemetry.Resources.OperatingSystem infra Infra work - CI/CD, code coverage, linters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants