-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Resources.OperatingSystem] Fix issue with detecting MacOS #1965
Merged
Kielek
merged 12 commits into
open-telemetry:main
from
ysolomchenko:fix-operating-system-detector
Jul 22, 2024
Merged
[Resources.OperatingSystem] Fix issue with detecting MacOS #1965
Kielek
merged 12 commits into
open-telemetry:main
from
ysolomchenko:fix-operating-system-detector
Jul 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
comp:resources.operatingsystem
Things related to OpenTelemetry.Resources.OperatingSystem
label
Jul 17, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1965 +/- ##
==========================================
+ Coverage 73.91% 74.69% +0.77%
==========================================
Files 267 299 +32
Lines 9615 11144 +1529
==========================================
+ Hits 7107 8324 +1217
- Misses 2508 2820 +312 Flags with carried forward coverage won't be shown. Click here to find out more.
|
ysolomchenko
force-pushed
the
fix-operating-system-detector
branch
from
July 18, 2024 07:13
737d35e
to
3f75811
Compare
pellared
reviewed
Jul 18, 2024
pellared
approved these changes
Jul 18, 2024
Co-authored-by: Robert Pająk <pellared@hotmail.com>
lachmatt
reviewed
Jul 18, 2024
src/OpenTelemetry.Resources.OperatingSystem/OperatingSystemDetector.cs
Outdated
Show resolved
Hide resolved
lachmatt
approved these changes
Jul 19, 2024
Kielek
approved these changes
Jul 22, 2024
ezhang6811
pushed a commit
to ezhang6811/opentelemetry-dotnet-contrib
that referenced
this pull request
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp:resources.operatingsystem
Things related to OpenTelemetry.Resources.OperatingSystem
infra
Infra work - CI/CD, code coverage, linters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # Fix issue with detecting MacOS
Changes
Fix issue with detecting MacOS
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes