Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Resources.OperatingSystem] Implement additional osdetector attributes #1983

Merged
merged 31 commits into from
Aug 30, 2024

Conversation

ysolomchenko
Copy link
Contributor

@ysolomchenko ysolomchenko commented Jul 31, 2024

Fixes #1957

Changes

Implement additional Operating System Detector attributes
https://github.com/open-telemetry/semantic-conventions/blob/main/docs/resource/os.md

The data detected by our detector comes from the same sources as those used by the opentelemetry-go detector.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@github-actions github-actions bot requested review from Kielek and lachmatt July 31, 2024 10:52
@github-actions github-actions bot added the comp:resources.operatingsystem Things related to OpenTelemetry.Resources.OperatingSystem label Jul 31, 2024
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 79.66102% with 24 lines in your changes missing coverage. Please review.

Project coverage is 80.00%. Comparing base (71655ce) to head (50f5935).
Report is 395 commits behind head on main.

Files with missing lines Patch % Lines
...sources.OperatingSystem/OperatingSystemDetector.cs 84.25% 17 Missing ⚠️
...atingSystem/OperatingSystemResourcesEventSource.cs 30.00% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1983      +/-   ##
==========================================
+ Coverage   73.91%   80.00%   +6.08%     
==========================================
  Files         267        3     -264     
  Lines        9615      130    -9485     
==========================================
- Hits         7107      104    -7003     
+ Misses       2508       26    -2482     
Flag Coverage Δ
unittests-Resources.OperatingSystem 80.00% <79.66%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...atingSystem/OperatingSystemResourcesEventSource.cs 30.00% <30.00%> (ø)
...sources.OperatingSystem/OperatingSystemDetector.cs 83.89% <84.25%> (ø)

... and 268 files with indirect coverage changes

@ysolomchenko
Copy link
Contributor Author

The Docker image doesn’t include an OS build ID, which is causing test errors. We need to find a way to track or include build IDs to resolve this issue.

@github-actions github-actions bot added the infra Infra work - CI/CD, code coverage, linters label Aug 1, 2024
@ysolomchenko ysolomchenko force-pushed the add-additional-os-attributes branch from b5cb64e to d0d2cb5 Compare August 1, 2024 12:11
@github-actions github-actions bot removed the infra Infra work - CI/CD, code coverage, linters label Aug 1, 2024
@ysolomchenko ysolomchenko marked this pull request as ready for review August 6, 2024 08:13
@ysolomchenko ysolomchenko requested a review from a team August 6, 2024 08:13
@ysolomchenko ysolomchenko changed the title Implement additional osdetector attributes [Resources.OperatingSystem] Implement additional osdetector attributes Aug 6, 2024
@Kielek Kielek merged commit fbca637 into open-telemetry:main Aug 30, 2024
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:resources.operatingsystem Things related to OpenTelemetry.Resources.OperatingSystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Populate additional os fields
4 participants