Add .NET 9 in tests projects #2313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
infra
xiang17
commented
Nov 12, 2024
…ore.App.Ref with version (= 8.0.11)`. However 8.0.11 was released less than 20 min ago. Maybe the restore step had a delay and didn't get the new version yet? D:\a\opentelemetry-dotnet-contrib\opentelemetry-dotnet-contrib\src\OpenTelemetry.Exporter.Geneva\OpenTelemetry.Exporter.Geneva.csproj : error NU1102: Unable to find package Microsoft.AspNetCore.App.Ref with version (= 8.0.11) D:\a\opentelemetry-dotnet-contrib\opentelemetry-dotnet-contrib\src\OpenTelemetry.Exporter.Geneva\OpenTelemetry.Exporter.Geneva.csproj : error NU1102: - Found 128 version(s) in NuGet [ Nearest version: 9.0.0-preview.1.24081.5 ] D:\a\opentelemetry-dotnet-contrib\opentelemetry-dotnet-contrib\src\OpenTelemetry.Exporter.Geneva\OpenTelemetry.Exporter.Geneva.csproj : error NU1102: - Found 0 version(s) in C:\Program Files\dotnet\library-packs Failed to restore D:\a\opentelemetry-dotnet-contrib\opentelemetry-dotnet-contrib\src\OpenTelemetry.Exporter.Geneva\OpenTelemetry.Exporter.Geneva.csproj (in 20.62 sec).
…uild-test-exporter-geneva-integration / build-test (ubuntu-24.04, net8.0) runs on Ubuntu 22.04.1 LTS. If not set, the version is newer. For example, build-test-exporter-influxdb / build-test (ubuntu-latest, net8.0) runs on Ubuntu 22.04.5 LTS.
…T SDK in a docker.
…fail in GitHub CI for now, both for confluentkafka-integration and stackexchangeredis-integration. The current latest SDK in mcr.microsoft.com/dotnet/sdk:9.0 is 9.0.100-rc.2.24474.11, as shown in CI. I'll revert global.json to use rc.2 for now.
…ow to be inspected later.
… doesn't have net9.0 targets yet. I'll leave to the component owners to upgrade them.
# Conflicts: # build/Common.nonprod.props
github-actions
bot
added
the
comp:instrumentation.grpccore
github-actions
bot
removed
the
documentation
github-actions
bot
added
comp:instrumentation.stackexchangeredis
xiang17
changed the title
4 tasks
...metry.Instrumentation.AspNetCore.Tests/OpenTelemetry.Instrumentation.AspNetCore.Tests.csproj
Outdated
Show resolved
Hide resolved
rajkumar-rangaraj
approved these changes
Nov 14, 2024
I think they're not needed. There is a discussion around it since long ago. Here's a recent one: open-telemetry/opentelemetry-dotnet#5832 (comment) The conclusion is that it's not needed (especially if it's not a LTS). However, sometimes it does bring some benefits. I think we can skip adding new target frameworks to projects unless there is a specific reason to do so. (This is regarding to projects under |
Kielek
reviewed
Nov 14, 2024
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| <PropertyGroup> | |||
| <!-- OmniSharp/VS Code requires TargetFrameworks to be in descending order for IntelliSense and analysis. --> | |||
| <TargetFrameworks>$(SupportedNetTargets)</TargetFrameworks> | |||
| <TargetFrameworks>$(SupportedNetTargetsWithoutNet9)</TargetFrameworks> | |||
There was a problem hiding this comment.
Instrumentaiton.StackExchangeRedis - support .NET9
There was a problem hiding this comment.
They have a lot of failures after adding net9.0. I think it's easier to manage to leave them out of this PR.
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| <PropertyGroup> | |||
| <!-- OmniSharp/VS Code requires TargetFrameworks to be in descending order for IntelliSense and analysis. --> | |||
| <TargetFrameworks>$(SupportedNetTargets)</TargetFrameworks> | |||
| <TargetFrameworks>$(SupportedNetTargetsWithoutNet9)</TargetFrameworks> | |||
There was a problem hiding this comment.
Resources.AWS - support .NET9
This was referenced Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #2319.
Changes
Add .NET 9 target framework in tests for all libraries except for
OpenTelemetry.Instrumentation.StackExchangeRedis.TestsandOpenTelemetry.Resources.AWS.Testsbecause the tests are failing.SupportedNetTargetsWithoutNet9is added for them..Merge requirement checklist
[ ] Appropriate: only updated tests.CHANGELOG.mdfiles updated for non-trivial changes[ ] Changes in public API reviewed (if applicable)