#229: NullReferenceException in TelemetryDispatchMessageInspector.BeforeSendReply when operation is OneWay #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
open-telemetry#229: Check if reply is not null
|
@ievgen-platonov This looks good to me, thanks for the contribution! Would you mind updating the CHANGELOG? You can add a section for "1.0.0-rc6" that's the version I'll use to release the fix. |
Codecov Report
@@ Coverage Diff @@
## main #237 +/- ##
=======================================
Coverage 79.14% 79.14%
=======================================
Files 97 97
Lines 2498 2498
=======================================
Hits 1977 1977
Misses 521 521 |
|
@CodeBlanch Sure. Done. |
|
@iepl Hey it looks like the markdownlint task failed on your CHANGELOG update. Needs a blank line like... I tried to fix it for you but it looks like I don't have access to your branch. |
|
@CodeBlanch Fixed. I added some extra asserts as well. Just copied from existing test. |
swetharavichandrancisco
pushed a commit
to swetharavichandrancisco/opentelemetry-dotnet-contrib
that referenced
this pull request
Apr 4, 2022
…eInspector.BeforeSendReply when operation is OneWay (open-telemetry#237) * Update TelemetryDispatchMessageInspector.cs open-telemetry#229: Check if reply is not null * open-telemetry#229: Added TelemetryDispatchMessageInspectorForOneWayOperationsTests * open-telemetry#229: Rename parameters * open-telemetry#229: Added new "1.0.0-rc6" version to CHANGELOG.md * open-telemetry#229: Fix text formatting * open-telemetry#229: Fix CHANGELOG formatting. Added extra asserts to the test * open-telemetry#229: Fix formatting * open-telemetry#229: Fix formatting in GHANGELOG.md Co-authored-by: iepl <platonov.evgen@gmail.com> Co-authored-by: Ievgen Platonov <77076677+iepl@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See details in the issue #229 (#229)