Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WCF: Update package/assembly name, namespace, and supported .NET Framework versions #247

Merged
merged 3 commits into from
Mar 17, 2022
Merged

WCF: Update package/assembly name, namespace, and supported .NET Framework versions #247

merged 3 commits into from
Mar 17, 2022

Conversation

CodeBlanch
Copy link
Member

Towards #196

Notes:

  • This does not change the directory structure
  • This does change the namespaces. Since web.config/app.config-based WCF configuration can often involve fully qualified names, I thought this was important to do to prevent confusion/mistakes

@CodeBlanch CodeBlanch requested a review from a team March 17, 2022 19:17
@utpilla
Copy link
Contributor

utpilla commented Mar 17, 2022

We need to rename the folders under src\ and test\ for the release workflow to work. It need not be done in this PR.

@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #247 (b7f26e3) into main (5b9dc45) will not change coverage.
The diff coverage is n/a.

❗ Current head b7f26e3 differs from pull request most recent head 0c87a38. Consider uploading reports for the commit 0c87a38 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #247   +/-   ##
=======================================
  Coverage   79.14%   79.14%           
=======================================
  Files          97       97           
  Lines        2498     2498           
=======================================
  Hits         1977     1977           
  Misses        521      521
Impacted Files Coverage Δ
...strumentation.Wcf/Implementation/ActionMetadata.cs 100.00% <ø> (ø)
...Implementation/WcfInstrumentationActivitySource.cs 92.30% <ø> (ø)
...cf/Implementation/WcfInstrumentationEventSource.cs 26.31% <ø> (ø)
...rumentation.Wcf/TelemetryClientMessageInspector.cs 83.11% <ø> (ø)
...entation.Wcf/TelemetryContractBehaviorAttribute.cs 0.00% <ø> (ø)
...b.Instrumentation.Wcf/TelemetryEndpointBehavior.cs 92.85% <ø> (ø)
...rumentation.Wcf/TracerProviderBuilderExtensions.cs 75.00% <ø> (ø)
...b.Instrumentation.Wcf/WcfInstrumentationOptions.cs 80.00% <ø> (ø)

@CodeBlanch CodeBlanch merged commit af709ae into open-telemetry:main Mar 17, 2022
@CodeBlanch CodeBlanch deleted the wcf-cleanup branch March 17, 2022 19:33
@CodeBlanch CodeBlanch mentioned this pull request Mar 17, 2022
Merged
swetharavichandrancisco pushed a commit to swetharavichandrancisco/opentelemetry-dotnet-contrib that referenced this pull request Apr 4, 2022
@CodeBlanch @swetharavichandrancisco
WCF: Update package/assembly name, namespace, and supported .NET Fram…
0a1d95c 
…ework versions (open-telemetry#247)

* Update WCF assembly name, namespace, and supported .NET Framework version.

* CHANGELOG update.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utpilla utpilla utpilla approved these changes

Assignees

@CodeBlanch CodeBlanch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CodeBlanch @utpilla