Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the native Activity properties Status and StatusDescription #359

Merged
merged 4 commits into from
May 13, 2022

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented May 12, 2022

Related to open-telemetry/opentelemetry-dotnet#2569

Changes

  • Add support for the native Activity properties Status and StatusDescription for GenevaExporter. All the other exporters in the public repo have added support for the native Activity properties Status and StatusDescription.

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes

Benchmark Results

There is no measurable impact on the perf numbers.

// * Summary *

BenchmarkDotNet=v0.13.1, OS=Windows 10.0.22000
Intel Core i7-9700 CPU 3.00GHz, 1 CPU, 8 logical and 8 physical cores
.NET SDK=6.0.300
[Host] : .NET 6.0.5 (6.0.522.21309), X64 RyuJIT
DefaultJob : .NET 6.0.5 (6.0.522.21309), X64 RyuJIT

main branch

Method Mean Error StdDev Gen 0 Allocated
CreateBoringActivity 16.83 ns 0.180 ns 0.168 ns - -
CreateTediousActivity 319.15 ns 2.474 ns 2.193 ns 0.0648 408 B
CreateInterestingActivity 631.70 ns 3.194 ns 2.832 ns 0.0648 408 B
SerializeActivity 490.15 ns 6.587 ns 6.161 ns 0.0124 80 B

With the changes in this PR

Method Mean Error StdDev Gen 0 Allocated
CreateBoringActivity 16.95 ns 0.338 ns 0.316 ns - -
CreateTediousActivity 309.26 ns 1.010 ns 0.843 ns 0.0648 408 B
CreateInterestingActivity 635.43 ns 7.435 ns 6.591 ns 0.0648 408 B
SerializeActivity 492.03 ns 4.338 ns 4.058 ns 0.0124 80 B

@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #359 (9120926) into main (5608616) will increase coverage by 0.33%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #359      +/-   ##
==========================================
+ Coverage   25.25%   25.58%   +0.33%     
==========================================
  Files         126      126              
  Lines        3778     3795      +17     
==========================================
+ Hits          954      971      +17     
  Misses       2824     2824              
Impacted Files Coverage Δ
...enTelemetry.Exporter.Geneva/GenevaTraceExporter.cs 90.86% <100.00%> (+0.81%) ⬆️

@utpilla utpilla merged commit 451e14f into open-telemetry:main May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants