Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix using version 3.7.100 of AWS SDK causing exception not finding EndpointResolver #726

Merged
merged 3 commits into from
Oct 25, 2022
Merged

Fix using version 3.7.100 of AWS SDK causing exception not finding EndpointResolver #726

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7ee920b
Fixed using version 3.7.100 of AWS SDK causing exception not finding …
normj Oct 21, 2022
e08e45e
Update src/OpenTelemetry.Contrib.Instrumentation.AWS/CHANGELOG.md
normj Oct 25, 2022
17e4464
Merge branch 'main' into main
utpilla Oct 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/OpenTelemetry.Contrib.Instrumentation.AWS/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Changelog - OpenTelemetry.Contrib.Instrumentation.AWS

## Unreleased

* Fixed issue when using version 3.7.100 of the AWS SDK for .NET triggering an
EndpointResolver not found exception.
normj marked this conversation as resolved.
Show resolved Hide resolved

## 1.0.1

Released 2021-Feb-24
Expand Down
2 changes: 1 addition & 1 deletion src/OpenTelemetry.Contrib.Instrumentation.AWS/Implementation/AWSTracingPipelineCustomizer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,6 @@ public void Customize(Type serviceClientType, RuntimePipeline pipeline)
return;
}

pipeline.AddHandlerAfter<EndpointResolver>(new AWSTracingPipelineHandler(this.options));
pipeline.AddHandlerBefore<RetryHandler>(new AWSTracingPipelineHandler(this.options));
}
}