Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request release of OpenTelemetry.Contrib.Instrumentation.AWS #765

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

normj
Copy link
Contributor

@normj normj commented Nov 10, 2022

Request release of OpenTelemetry.Contrib.Instrumentation.AWS because currently this library is broken for the current release of the AWS .NET SDK and was fixed by PR #726.

@open-telemetry/dotnet-contrib-maintainers

Changes

Updated CHANGELOG for release of the OpenTelemetry.Contrib.Instrumentation.AWS package.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #

@normj normj requested a review from a team November 10, 2022 05:43
@github-actions github-actions bot requested a review from srprash November 10, 2022 05:43
@@ -1,6 +1,8 @@
# Changelog - OpenTelemetry.Contrib.Instrumentation.AWS

## Unreleased
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default we keep empty, unreleased section. Could you please bring it back?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem. Added back.

@normj normj force-pushed the request-auto-aws-release branch from 83d4df7 to d1c54e1 Compare November 10, 2022 05:58
Copy link
Contributor

@Kielek Kielek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@open-telemetry/dotnet-contrib-maintainers, please check.

@utpilla utpilla merged commit 82b03ee into open-telemetry:main Nov 10, 2022
@utpilla utpilla added the comp:instrumentation.aws Things related to OpenTelemetry.Instrumentation.AWS label Nov 10, 2022
@utpilla
Copy link
Contributor

utpilla commented Nov 10, 2022

@normj
Copy link
Contributor Author

normj commented Nov 10, 2022

Thanks @utpilla !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.aws Things related to OpenTelemetry.Instrumentation.AWS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants