Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing db providers to db.system #898

Merged
merged 18 commits into from
Mar 2, 2023
Merged

Add missing db providers to db.system #898

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
aec37c5
Initial work for db.systems
mrblonde91 Jan 13, 2023
d3cefcf
Include omitted systems
mrblonde91 Jan 15, 2023
a00fca7
Switch to ibm
mrblonde91 Jan 15, 2023
4731d3c
Update changelog
mrblonde91 Jan 15, 2023
b34b37e
Update naming
mrblonde91 Jan 16, 2023
9bd909e
Omit ibm
mrblonde91 Jan 25, 2023
c34a3d5
Merge branch 'main' into feature/updatesystems
Kielek Jan 26, 2023
e4ed7df
Merge branch 'main' into feature/updatesystems
mrblonde91 Jan 26, 2023
c40df84
Merge branch 'main' into feature/updatesystems
mrblonde91 Jan 30, 2023
1d409b6
Update src/OpenTelemetry.Instrumentation.EntityFrameworkCore/CHANGELO…
mrblonde91 Feb 2, 2023
b43012e
Merge branch 'main' into feature/updatesystems
mrblonde91 Feb 2, 2023
495749c
Merge branch 'main' into feature/updatesystems
mrblonde91 Feb 3, 2023
8d9c16a
Merge branch 'main' into feature/updatesystems
Kielek Feb 11, 2023
0303c49
Merge branch 'main' into feature/updatesystems
mrblonde91 Feb 15, 2023
662dbbc
Merge branch 'main' into feature/updatesystems
mrblonde91 Feb 17, 2023
358f234
Merge branch 'main' into feature/updatesystems
cijothomas Feb 22, 2023
83f0a5c
Merge branch 'main' into feature/updatesystems
Kielek Feb 23, 2023
3ef2e2a
Merge branch 'main' into feature/updatesystems
utpilla Mar 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/OpenTelemetry.Instrumentation.EntityFrameworkCore/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ Released 2023-Jan-25
* Added support to `EnrichWithIDbCommand`
([#868](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/868))

* Map missing dbs to system.db:
mrblonde91 marked this conversation as resolved.
Show resolved Hide resolved
`OpenTelemetry.Instrumentation.EntityFrameworkCore`
[#898](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/898)

## 1.0.0-beta.3

Released 2022-Mar-18
Expand Down
29 changes: 29 additions & 0 deletions ...y.Instrumentation.EntityFrameworkCore/Implementation/EntityFrameworkDiagnosticListener.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,18 +104,47 @@ public override void OnCustom(string name, Activity activity, object payload)
activity.AddTag(AttributeDbSystem, "cosmosdb");
break;
case "Microsoft.EntityFrameworkCore.Sqlite":
case "Devart.Data.SQLite.EFCore":
activity.AddTag(AttributeDbSystem, "sqlite");
break;
case "MySql.Data.EntityFrameworkCore":
case "Pomelo.EntityFrameworkCore.MySql":
case "Devart.Data.MySql.EFCore":
activity.AddTag(AttributeDbSystem, "mysql");
break;
case "Npgsql.EntityFrameworkCore.PostgreSQL":
case "Devart.Data.PostgreSql.EFCore":
activity.AddTag(AttributeDbSystem, "postgresql");
break;
case "Oracle.EntityFrameworkCore":
case "Devart.Data.Oracle.EFCore":
activity.AddTag(AttributeDbSystem, "oracle");
break;
case "Microsoft.EntityFrameworkCore.InMemory":
activity.AddTag(AttributeDbSystem, "efcoreinmemory");
break;
case "FirebirdSql.EntityFrameworkCore.Firebird":
activity.AddTag(AttributeDbSystem, "firebird");
break;
case "FileContextCore":
activity.AddTag(AttributeDbSystem, "filecontextcore");
break;
case "EntityFrameworkCore.SqlServerCompact35":
case "EntityFrameworkCore.SqlServerCompact40":
activity.AddTag(AttributeDbSystem, "mssqlcompact");
break;
case "EntityFrameworkCore.OpenEdge":
activity.AddTag(AttributeDbSystem, "openedge");
break;
case "EntityFrameworkCore.Jet":
activity.AddTag(AttributeDbSystem, "jet");
break;
case "Google.Cloud.EntityFrameworkCore.Spanner":
activity.AddTag(AttributeDbSystem, "spanner");
break;
case "Teradata.EntityFrameworkCore":
activity.AddTag(AttributeDbSystem, "teradata");
break;
default:
activity.AddTag(AttributeDbSystem, "other_sql");
activity.AddTag("ef.provider", providerName);
Expand Down