Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format native code using clang-format #2101

Merged
merged 16 commits into from
Feb 2, 2023
Merged

Format native code using clang-format #2101

merged 16 commits into from
Feb 2, 2023

Conversation

pellared
Copy link
Member

@pellared pellared commented Jan 30, 2023 •
edited
Loading

Why

Fixes #1356

What

Tests

CI + manual locally

Checklist

  • CHANGELOG.md is updated.
  • Documentation is updated.
  • New features are covered by tests.

@github-actions github-actions bot requested a review from theletterf January 30, 2023 13:44
pellared
pellared commented Jan 30, 2023
View reviewed changes
scripts/format-native.sh
fi

# files to format
NATIVE_FILES=$(find . -iname *.cpp -o -iname *.hpp -iname *.h -iname *.inc | grep -v ./packages | grep -v ./src/OpenTelemetry.AutoInstrumentation.Native/lib)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is the main reason why it is not yet implemented in Nuke. I think we can create an issue to move the formatting logic to Nuke targets. Let me know what you think if we should address it ASAP or can we postpone it.

@pellared pellared changed the title [WIP] Format native code Format native code using clang-format Jan 30, 2023
@pellared pellared marked this pull request as ready for review January 30, 2023 14:05
@pellared pellared requested a review from a team January 30, 2023 14:05
@pellared
Copy link
Member Author

@open-telemetry/dotnet-maintainers I suggest merging #2088 before this PR.

@Kielek Kielek enabled auto-merge (squash) February 2, 2023 11:23
@Kielek Kielek merged commit b773b72 into open-telemetry:main Feb 2, 2023
@pellared pellared deleted the clang-format branch March 14, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacharycmontoya zacharycmontoya zacharycmontoya approved these changes

@Kielek Kielek Kielek approved these changes

@theletterf theletterf Awaiting requested review from theletterf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Format native code
3 participants
@pellared @Kielek @zacharycmontoya