Bump OpenTelemetry packages to 1.8.0 releases #3351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kielek
commented
Apr 5, 2024
| <PackageVersion Include="OpenTelemetry.Instrumentation.Quartz" Version="1.0.0-beta.2" /> | ||
| <PackageVersion Include="OpenTelemetry.Instrumentation.Runtime" Version="1.8.0" /> | ||
| <PackageVersion Include="OpenTelemetry.Instrumentation.SqlClient" Version="1.8.0-beta.1" /> | ||
| <PackageVersion Include="OpenTelemetry.Instrumentation.StackExchangeRedis" Version="1.0.0-rc9.14" /> | ||
| <PackageVersion Include="OpenTelemetry.Shims.OpenTracing" Version="1.7.0-beta.1" /> |
There was a problem hiding this comment.
What is your opinion about this package?
There is no changes sinse 1.7.0-beta.1 release. The only thing we can achieve is upgrade transitive dependency from OpenTelemetry.Api 1.7.0 to 1.8.0.
We ship 1.8.0 even without this change. If needed, we need to ask SDK team for the release.
@rajkumar-rangaraj, FYI.
There was a problem hiding this comment.
I recommend shipping without any additional changes. These are not stable packages; we should rely on .NET to transitively upgrade the dependencies for these libraries from 1.7.0 to 1.8.0.
It’s a maintenance overhead for the SDK team to just modify these package dependencies to 1.8.0 and release another version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fixes #3328
What
Bump OpenTelemetry packages to 1.8.0 releases
Move support for
OTEL_TRACES_SAMPLERandOTEL_TRACES_SAMPLER_ARGto SDK by open-telemetry/opentelemetry-dotnet#5448Tests
CI
Checklist
CHANGELOG.mdis updated.Newfeatures are covered by tests.