Bump FluentAssertions from 7.0.0 to 8.0.0 #3934
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
There was a problem hiding this comment.
Blocking merge. We need to double check if we can use this package.
It changed the license from Apache 2.0 to some custom version: fluentassertions/fluentassertions#2943
|
I'm surprised dependabot blindly updates libraries even if the license changed and without even warning about it. |
|
@nicolas17, it references release notes. It is first line there. |
|
SIG meeting update: We discussed whether we should just keep this reference pinned to 7.0.0 or to migrate away from this library. To keep things simple (especially for any forks of this project), and following the precedent in other repos, we decided that we should just migrate to the xunit assertion library. |
|
@Kielek whats your migration stratergy? Regex find and replace? |
|
@mikes-gh, you have couple of options here:
For this project, the fastest option was go throw mix of 1 (mostly) and 2. |
|
Thanks @Kielek we have 6800 |
dependabot
bot
force-pushed
the
dependabot/nuget/FluentAssertions-8.0.0
branch
from
20f3f44 to
80709d5
Compare
Bumps [FluentAssertions](https://github.com/fluentassertions/fluentassertions) from 7.0.0 to 8.0.0. - [Release notes](https://github.com/fluentassertions/fluentassertions/releases) - [Changelog](https://github.com/fluentassertions/fluentassertions/blob/develop/AcceptApiChanges.ps1) - [Commits](fluentassertions/fluentassertions@7.0.0...8.0.0) --- updated-dependencies: - dependency-name: FluentAssertions dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/nuget/FluentAssertions-8.0.0
branch
from
80709d5 to
0b36f7d
Compare
|
Looks like FluentAssertions is no longer a dependency, so this is no longer needed. |
Bumps FluentAssertions from 7.0.0 to 8.0.0.
Release notes
Sourced from FluentAssertions's releases.
... (truncated)
Commits
901c8faMerge pull request #2947 from fluentassertions/release-8.0df7e9bfUpdate ownership and license65d78e2Merge pull request #2945 from fluentassertions/mainbfbf509Update landing page (#2944)f77fe32Bump the xunit group with 3 updates266fedeBump Microsoft.Testing.Extensions.TrxReport from 1.5.0 to 1.5.1e5283d0Bump Meziantou.Analyzer from 2.0.184 to 2.0.1863d8f03fFix several link texts7426493Fix release note PR-linkbcc974bSimplify FirstOrDefault() + null check to Any()Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)