Test when periodic metric reader options is null

open-telemetry · Apr 15, 2022 · 162650b · 162650b
1 parent 2bd97bf
commit 162650b
Showing 1 changed file with 29 additions and 11 deletions.
diff --git a/test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/OtlpMetricsExporterTests.cs b/test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/OtlpMetricsExporterTests.cs
@@ -47,21 +47,39 @@ public void TestAddOtlpExporter_SetsCorrectMetricReaderDefaults()
                 .AddOtlpExporter()
                 .Build();
 
-            var bindingFlags = System.Reflection.BindingFlags.NonPublic | System.Reflection.BindingFlags.Instance;
+            CheckMetricReaderDefaults();
 
-            var metricReader = typeof(MetricReader)
-                .Assembly
-                .GetType("OpenTelemetry.Metrics.MeterProviderSdk")
-                .GetField("reader", bindingFlags)
-                .GetValue(meterProvider) as PeriodicExportingMetricReader;
+            meterProvider.Dispose();
 
-            Assert.NotNull(metricReader);
+            meterProvider = Sdk.CreateMeterProviderBuilder()
+                .AddOtlpExporter((exporterOptions, metricReaderOptions) =>
+                {
+                    metricReaderOptions.PeriodicExportingMetricReaderOptions = null;
+                })
+                .Build();
+
+            CheckMetricReaderDefaults();
+
+            meterProvider.Dispose();
 
-            var exportIntervalMilliseconds = (int)typeof(PeriodicExportingMetricReader)
-                .GetField("ExportIntervalMilliseconds", bindingFlags)
-                .GetValue(metricReader);
+            void CheckMetricReaderDefaults()
+            {
+                var bindingFlags = System.Reflection.BindingFlags.NonPublic | System.Reflection.BindingFlags.Instance;
+
+                var metricReader = typeof(MetricReader)
+                    .Assembly
+                    .GetType("OpenTelemetry.Metrics.MeterProviderSdk")
+                    .GetField("reader", bindingFlags)
+                    .GetValue(meterProvider) as PeriodicExportingMetricReader;
+
+                Assert.NotNull(metricReader);
 
-            Assert.Equal(60000, exportIntervalMilliseconds);
+                var exportIntervalMilliseconds = (int)typeof(PeriodicExportingMetricReader)
+                    .GetField("ExportIntervalMilliseconds", bindingFlags)
+                    .GetValue(metricReader);
+
+                Assert.Equal(60000, exportIntervalMilliseconds);
+            }
         }
 
         [Fact]