Merge branch 'main' into ExportersGrabDefaultResource

open-telemetry · Feb 2, 2021 · 88846d0 · 88846d0
2 parents 4f21dbb + 7d8c403
commit 88846d0
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/src/OpenTelemetry/Trace/TracerProviderSdk.cs b/src/OpenTelemetry/Trace/TracerProviderSdk.cs
@@ -97,6 +97,14 @@ internal TracerProviderSdk(
                         return;
                     }
 
+                    // Spec says IsRecording must be false once span ends.
+                    // https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/api.md#isrecording
+                    // However, Activity has slightly different semantic
+                    // than Span and we don't have strong reason to do this
+                    // now, as Activity anyway allows read/write always.
+                    // Intentionally commenting the following line.
+                    // activity.IsAllDataRequested = false;
+
                     if (SuppressInstrumentationScope.DecrementIfTriggered() == 0)
                     {
                         this.processor?.OnEnd(activity);