Skip to content

Commit

Permalink
[otlp] Add comments capturing details about SYSLIB1100 & SYSLIB1101 s…
Browse files Browse the repository at this point in the history
…uppressions in project (#5523)
  • Loading branch information
CodeBlanch authored Apr 8, 2024
1 parent dde68fa commit 9261a67
Showing 1 changed file with 8 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,14 @@
<Nullable>disable</Nullable>
<DefineConstants>BUILDING_INTERNAL_PERSISTENT_STORAGE;$(DefineConstants)</DefineConstants>
<EnableConfigurationBindingGenerator>true</EnableConfigurationBindingGenerator>
<!-- SYSLIB1100;SYSLIB1101 - Configuration.Binder: can't create instance and unsupported type -->

<!-- Note: SYSLIB1100;SYSLIB1101 - Configuration.Binder: Can't create
instance and unsupported type are being emitted by config source generator
processing OtlpExporterBuilderOptions. It would be preferable to suppress
this at the call site but there is a bug. This could possibly be cleaned up
in the future (hopefully .NET 9) see:
https://github.com/open-telemetry/opentelemetry-dotnet/pull/5520#discussion_r1556221048
and https://github.com/dotnet/runtime/issues/92509 -->
<NoWarn>$(NoWarn);SYSLIB1100;SYSLIB1101</NoWarn>
</PropertyGroup>

Expand Down

0 comments on commit 9261a67

Please sign in to comment.